fix: use the flag for non-persistence

[ianna]

Using the flag for non-persistence of the PyObject lookup pointers prevents the crash.

[codecov]

Codecov Report

Merging #1781 (0559144) into main (f3a9412) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted Files	Coverage Δ
src/awkward/_connect/cling.py	24.90% <ø> (ø)
src/awkward/contents/indexedarray.py	79.76% <0.00%> (-0.19%)	⬇️
src/awkward/contents/recordarray.py	83.72% <0.00%> (-0.18%)	⬇️
src/awkward/_util.py	82.36% <0.00%> (-0.18%)	⬇️
src/awkward/contents/indexedoptionarray.py	88.92% <0.00%> (-0.16%)	⬇️
src/awkward/_connect/avro.py	87.17% <0.00%> (-0.14%)	⬇️
src/awkward/types/_awkward_datashape_parser.py	47.72% <0.00%> (-0.01%)	⬇️
src/awkward/contents/content.py	77.31% <0.00%> (+0.10%)	⬆️

[jpivarski]

This is different from what I thought you were saying (in person). So the //! is something you needed to add to get it to work. I'm willing to accept that this is ROOT magic that handles the PyObject* more appropriately (correct lifetime: DECREFed once and only once when the RDataSource is out of scope).

Do the tests really test what this is changing? That is, without the //! lookup comments, do the tests fail?

[agoose77]

I was curious about the //! markup, so I looked it up for my own benefit. Here's the link for anyone else finding this in the future: https://github.com/root-project/root/blob/07932d78211d0ac5fdb198ac2260c35530cb9647/io/doc/TFile/README.md#streamerinfo