refactor: hide L3 API #1983
Merged
refactor: hide L3 API #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto agoose77/refactor-l3-l4-split
agoose77
changed the title
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Dec 8, 2022
refactor: move `sort`, `argsort` to `ak._do`
|
I made the last fixes that follow from the list of changes in #1972. In a couple of places, I think I've made the code worse - |
jpivarski
approved these changes
Dec 9, 2022
| @@ -336,169 +336,6 @@ def dofunction(link, linelink, shortname, name, astfcn): | |||
| dofunction(link, linelink, shortname, toplevel.name, toplevel) | |||
|
|
|||
|
|
|||
| categories = [ | |||
There was a problem hiding this comment.
I see: categories is completely gone, now.
Comment on lines
-663
to
+645
| contiguous_self = self if self.is_contiguous else self.contiguous() | ||
| contiguous_self = self.to_contiguous() |
There was a problem hiding this comment.
I guess that was superfluous, considering that to_contiguous would return self if already contiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlevel,behaviorarguments to theak.XXXreducerslayout.XXXreducerslayout._reducetoak._do.reducelayout.layout_equaltoContent.is_equal_toNumpyArrayNumpyArray.maybe_to_array()withNumpyArray.maybe_to_NumpyArray()Content/Contentsubclass public method/propertiesContent.tolist()(but keep high-level implementation)validity_errortoak._do.validity_errorContent.typetracerwithContent.to_typetracer(...)Content.forget_length()with argument toContent.to_typetracer()ak.packed()toak.to_packed()(same forContent.packed())📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-refactor-l3-l4-split/ once Read the Docs has finished building 🔨