Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restore branch preview #1994

Merged
merged 24 commits into from
Dec 12, 2022
Merged

docs: restore branch preview #1994

merged 24 commits into from
Dec 12, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 12, 2022

This PR is the first step in moving our docs to AWS.

It creates a deployment whose URL leads to the rendered docs. Each branch lives for seven days after creation.

@agoose77 agoose77 changed the title wip: add switcher docs: add branch preview Dec 12, 2022
@agoose77 agoose77 temporarily deployed to S3_BUCKET = "awkward-array.org-test" December 12, 2022 12:42 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 13:27 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 13:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1994 (df59870) into main (91e7442) will not change coverage.
The diff coverage is n/a.

❗ Current head df59870 differs from pull request most recent head 85b997c. Consider uploading reports for the commit 85b997c to get more accurate results

Additional details and impacted files

@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 14:01 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 14:12 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 14:19 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 14:31 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 14:55 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 15:08 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 15:25 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 15:28 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 15:35 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 16:16 — with GitHub Actions Inactive
@agoose77 agoose77 marked this pull request as ready for review December 12, 2022 17:44
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 17:53 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 20:49 — with GitHub Actions Inactive
@agoose77
Copy link
Collaborator Author

OK, now the deployment includes the deployed URL, which is a nice touch.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before, I can't verify the correctness of this line-by-line, but I approve of the intention.

The "View Deployment" button is great. Is there any reason, now, for editing the PR description? Even though that works, it's a "moving part" that could fly off its axle and break something (maybe accidentally delete a carefully written PR message).

@agoose77
Copy link
Collaborator Author

Is there any reason, now, for editing the PR description?

Now that you mention it, no. Let's remove that, and increase the robustness.

@agoose77 agoose77 temporarily deployed to docs-preview December 12, 2022 21:52 — with GitHub Actions Inactive
@agoose77 agoose77 enabled auto-merge (squash) December 12, 2022 21:57
@agoose77 agoose77 merged commit 213f974 into main Dec 12, 2022
@agoose77 agoose77 deleted the agoose77/docs-aws-deploy branch December 12, 2022 21:59
@agoose77 agoose77 changed the title docs: add branch preview docs: restore branch preview Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants