fix: rebuild invalid check pointers in ArrayBuilder
#2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
check pointerscheck pointers in ArrayBuilder
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Jan 1, 2023
There was a problem hiding this comment.
This is definitely a different solution than what I had in mind, but it makes a lot of sense. Now _check and _fast are safe to mix (though a _check will slow down _fast).
I see that you've implemented this for both beginrecord_* and field_*.
This will require an increase in the awkward-cpp version.
jpivarski
added a commit
that referenced
this pull request
Jan 1, 2023
agoose77
pushed a commit
that referenced
this pull request
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2054, fixes #2053, which occur when a user mixes "fast" and "slow" modes of the record / field builders. The string pointers that are used to implement the fast mechanism are assumed to come from an intern pool, i.e. the same string has the same pointer. This fails when Python strings are used, as they come from different pools, and aren't guaranteed to be stable.
To correct this, we can ensure that the slow-mode invalidates any pointers, and that the fast-mode treats
nullptras a cue to rebuild the pointer.