fix: render keyword and varargs #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Jan 5, 2023
docs/prepare_docstrings.py
Outdated
Comment on lines
150
to
151
| if node.args.vararg is not None: | ||
| rendered.insert(len(node.args.posonlyargs + node.args.args), f"*{node.args.vararg.arg}") |
There was a problem hiding this comment.
This should handle the args in
def func(self, x, *args, y):
...
jpivarski
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
It does:
- http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/agoose77/docs-fix-keyword-only-rendering/reference/generated/ak.to_parquet.html
- http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/agoose77/docs-fix-keyword-only-rendering/reference/generated/ak.forms.RegularForm.html
|
I'm enabling auto-merge on this one because it seems very straightforward and done. Many of the tests haven't started, but I suspect that's because we're using the maximum number that we're allowed to use. If it's held up by the link-checker, then this branch will need to be updated when that goes into |
|
This won't run all the tests because we don't run build tests if the code isn't touched. If the non-queued tests all pass, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2073