ci: remove link checker #2075
Merged
ci: remove link checker #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
jpivarski
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
I see that this removes the link-checker (sphinx-build -M linkcheck) that we talked about on Slack.
What's the new prepare-release.yml? Is it something that we should run manually? It doesn't have the link-checker in it.
Oh! It sets version numbers. That's useful. Was it intended as part of this PR—is it ready?
@jpivarski 😳 glad you caught that. I don't know how that snuck in there; I always use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with Jim: checking links is useful, but the benefits do not outweigh the drawbacks RE flukiness & build time. In general, links break; we just need to run these tests locally on a schedule to ensure that nothing breaks due to mistyping.