Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken links due to cpp split #2087

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jan 7, 2023

Fixes #2081

We will also need to update our Git workflow such that C++ releases are assigned tags.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #2087 (c216308) into main (c4cb717) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_sort.py 60.00% <0.00%> (-40.00%) ⬇️
src/awkward/operations/ak_argsort.py 75.00% <0.00%> (-25.00%) ⬇️
src/awkward/operations/ak_ones_like.py 90.90% <0.00%> (-9.10%) ⬇️
src/awkward/operations/ak_zeros_like.py 92.85% <0.00%> (-7.15%) ⬇️
src/awkward/operations/ak_ravel.py 93.33% <0.00%> (-6.67%) ⬇️
src/awkward/operations/ak_isclose.py 94.44% <0.00%> (-5.56%) ⬇️
src/awkward/operations/ak_count_nonzero.py 77.27% <0.00%> (-2.73%) ⬇️
src/awkward/operations/ak_nan_to_num.py 98.03% <0.00%> (-1.97%) ⬇️
src/awkward/operations/ak_full_like.py 98.07% <0.00%> (-1.93%) ⬇️
src/awkward/operations/ak_all.py 78.26% <0.00%> (-1.74%) ⬇️
... and 14 more

@agoose77 agoose77 temporarily deployed to docs-preview January 7, 2023 21:30 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview January 8, 2023 01:17 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview January 9, 2023 18:18 — with GitHub Actions Inactive
@agoose77
Copy link
Collaborator Author

agoose77 commented Jan 9, 2023

The branch preview try-it link can be used to verify that the following links to the correct URL:

ak.to_regular([
    [1,2,3],
    [4,5]
])

@agoose77 agoose77 marked this pull request as ready for review January 9, 2023 18:59
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! With this one small fix:

awkward-cpp/include/awkward/common.h Outdated Show resolved Hide resolved
Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
@agoose77 agoose77 enabled auto-merge (squash) January 9, 2023 20:01
@agoose77 agoose77 temporarily deployed to docs-preview January 9, 2023 20:15 — with GitHub Actions Inactive
@agoose77 agoose77 merged commit 42404f2 into main Jan 9, 2023
@agoose77 agoose77 deleted the agoose77/chore-fix-cpp-links branch January 9, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awkward-cpp debug URLs are broken
2 participants