Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: be more permissive with sort translation #2112

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jan 12, 2023

Fixes #2110 and removes the awkward_quick_sort kernel.

NumPy is moving away from naming sort algorithms. We're interpreting a specific algorithm here as "stable" or "unstable", and using that flag instead.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2112 (e70a9a2) into main (6efa287) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_argsort.py 75.00% <0.00%> (ø)
src/awkward/operations/ak_sort.py 60.00% <0.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview January 12, 2023 17:45 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. PyLint wants you to use kind in (A, B) instead of kind == A or kind == B. I'll do that and turn on auto-merge.

src/awkward/operations/ak_argsort.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_argsort.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_sort.py Outdated Show resolved Hide resolved
src/awkward/operations/ak_sort.py Outdated Show resolved Hide resolved
@jpivarski jpivarski enabled auto-merge (squash) January 12, 2023 19:19
@jpivarski jpivarski temporarily deployed to docs-preview January 12, 2023 19:28 — with GitHub Actions Inactive
@jpivarski jpivarski merged commit 5a7d993 into main Jan 12, 2023
@jpivarski jpivarski deleted the agoose77/fix-sort-permissive branch January 12, 2023 19:38
@agoose77
Copy link
Collaborator Author

This is good. PyLint wants you to use kind in (A, B) instead of kind == A or kind == B. I'll do that and turn on auto-merge.

Actually, I prefer that ­— my code-style is moving around in-line with Awkward, and sometimes gets a bit confused ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEP-18 sort kind translation is incorrect
2 participants