Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve error message #2201

Merged
merged 2 commits into from
Feb 3, 2023
Merged

docs: improve error message #2201

merged 2 commits into from
Feb 3, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Feb 3, 2023 •
edited
Loading

Fixes #2200

@jpivarski oops, I should have left this for one-hour-fix. Sorry!

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #2201 (0ae9f8f) into main (4cc61df) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/recordarray.py 84.91% <ø> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview February 3, 2023 16:08 — with GitHub Actions Inactive
jpivarski
jpivarski approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to avoid doing the one-hour-fix issues. (There will be plenty of them.) We shouldn't take that label as an "assigned to," since there's another button for that, but literally as "if you're looking for a quick thing to fix, do this one."

@jpivarski jpivarski merged commit bf9daf2 into main Feb 3, 2023
@jpivarski jpivarski deleted the agoose77/docs-remove-mention-flatten-records branch February 3, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ak.any Error message gives suggestion which will also error
2 participants
@agoose77 @jpivarski