-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: keep column order after filtering flag #2234
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpivarski - please, have a look. I think, I'm done with this PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I see that out
is the result of an ak.zip
with depth_limit=1
, so it's a RecordArray
. Reordering this with IndexedArray
is what we typically do.
I just noticed that from_rdataframe
doesn't have highlevel
and behavior
arguments, though almost all of the ak.*
operations do. As it is, this assumes highlevel=True, behavior=None
. As possible, low-priority future work (independently of this PR), it would be nice to add these arguments.
Codecov didn't run, but I'm going to ignore that and merge it anyway. |
No description provided.