Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep column order after filtering flag #2234

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented Feb 13, 2023

No description provided.

@ianna ianna marked this pull request as draft February 13, 2023 11:05
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #2234 (10413c5) into main (4e01cc4) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

❗ Current head 10413c5 differs from pull request most recent head a7f1dd4. Consider uploading reports for the commit a7f1dd4 to get more accurate results

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_connect/rdataframe/to_rdataframe.py 0.00% <ø> (ø)
src/awkward/operations/ak_from_rdataframe.py 17.64% <66.66%> (ø)
...rc/awkward/operations/ak_merge_union_of_records.py 88.70% <0.00%> (-9.33%) ⬇️
src/awkward/_nplikes/array_module.py 89.84% <0.00%> (-0.16%) ⬇️
src/awkward/_slicing.py 87.40% <0.00%> (-0.15%) ⬇️
src/awkward/operations/ak_full_like.py 98.18% <0.00%> (-0.10%) ⬇️
src/awkward/_do.py 84.39% <0.00%> (ø)
src/awkward/_util.py 74.42% <0.00%> (ø)
src/awkward/forms/listform.py 83.14% <0.00%> (ø)
... and 25 more

@ianna ianna temporarily deployed to docs-preview February 13, 2023 11:17 — with GitHub Actions Inactive
@ianna ianna temporarily deployed to docs-preview February 13, 2023 15:00 — with GitHub Actions Inactive
@ianna ianna marked this pull request as ready for review February 20, 2023 10:41
Copy link
Collaborator Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpivarski - please, have a look. I think, I'm done with this PR. Thanks!

@ianna ianna requested a review from jpivarski February 20, 2023 10:46
@ianna ianna temporarily deployed to docs-preview February 20, 2023 10:59 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I see that out is the result of an ak.zip with depth_limit=1, so it's a RecordArray. Reordering this with IndexedArray is what we typically do.

I just noticed that from_rdataframe doesn't have highlevel and behavior arguments, though almost all of the ak.* operations do. As it is, this assumes highlevel=True, behavior=None. As possible, low-priority future work (independently of this PR), it would be nice to add these arguments.

@jpivarski
Copy link
Member

Codecov didn't run, but I'm going to ignore that and merge it anyway.

@jpivarski jpivarski merged commit e8ecf55 into main Feb 20, 2023
@jpivarski jpivarski deleted the ianna/rdf-keep-column-order-after-filtering branch February 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants