docs: fix build for latest theme #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
temporarily deployed
to
docs-preview
GitHub Actions
Inactive
jpivarski
approved these changes
Feb 28, 2023
Comment on lines
-1
to
-4
| {%- extends "sphinx_rtd_theme/breadcrumbs.html" %} | ||
|
|
||
| {% block breadcrumbs_aside %} | ||
| {% endblock %} |
There was a problem hiding this comment.
We had a custom breadcrumbs.html to remove some feature, probably an "edit on GitHub" link that didn't work because of how things were set up. Is all of that obsolete now?
There was a problem hiding this comment.
This currently doesn't do anything as we don't use sphinx_rtd_theme. However, pydata_sphinx_theme just added breadcrumbs, so now this no-op template loads and breaks things. We should probably re-introduce the feature that this template provided, on a more selective basis; generated listings, unlike the user guide, are not editable. I'll look into that in a new PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2273