chore: update pyodide parts a bit #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hitting: Which appears on main, too. |
agoose77
reviewed
Jun 22, 2023
| set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE) | ||
| set(CMAKE_INSTALL_RPATH "@loader_path") | ||
| elseif(EMSCRIPTEN) | ||
| if(CMAKE_SYSTEM_NAME STREQUAL Emscripten) |
There was a problem hiding this comment.
Yes! This is much better.
agoose77
reviewed
Jun 22, 2023
| @@ -105,6 +102,7 @@ target_link_libraries(awkward PRIVATE awkward-cpu-kernels-static ${CMAKE_DL_LIBS | |||
| target_link_libraries(awkward PUBLIC awkward-parent) | |||
|
|
|||
| # Third tier: Python modules. | |||
| find_package(Python REQUIRED COMPONENTS Interpreter Development.Module) | |||
There was a problem hiding this comment.
Doesn't pybind11 handle this for us? We don't link against these targets in this module.
There was a problem hiding this comment.
It defaults to the old FindPythonLibs/FindPythonInterp. You can use a variable to force the new search, or just search for it first.
If you build outside of scikit-build-core and want PyPy support, it's better to use the variable.
There was a problem hiding this comment.
(this is going to matter in CMake 3.27 which removes FindPythonLibs/FindPythonInterp if you set 3.27 as your max or min version)
agoose77
force-pushed
the
henryiii/chore/pyodide
branch
from
10852ae
to
5a7f57f
Compare
…d into henryiii/chore/pyodide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.