Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Python 3.7 #2557

Merged
merged 12 commits into from
Jul 4, 2023
Merged

chore: drop Python 3.7 #2557

merged 12 commits into from
Jul 4, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jul 2, 2023

Our deprecation schedule earmarked the July 2.3.0 release for dropping Python 3.7 support. This PR updates our CI, and package metadata, to reflect this change.

@agoose77
Copy link
Collaborator Author

agoose77 commented Jul 2, 2023

@henryiii I'd be interested in your thoughts about dropping lower bounds on dependencies that are already implied by the Python version. In this case, the NumPy lower bound is technically 1.18, but that's already imposed by the Python constraint of 3.8. What do you think about this, is it reasonable to remove the LB, or does it remove useful information?

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #2557 (d275653) into main (fb612e8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/numpy.py 92.18% <ø> (+0.31%) ⬆️
src/awkward/highlevel.py 76.96% <ø> (ø)
src/awkward/_nplikes/numpy.py 94.28% <100.00%> (+28.83%) ⬆️
src/awkward/_typing.py 91.66% <100.00%> (+0.75%) ⬆️

@agoose77 agoose77 temporarily deployed to docs-preview July 2, 2023 17:30 — with GitHub Actions Inactive
@agoose77 agoose77 temporarily deployed to docs-preview July 2, 2023 18:16 — with GitHub Actions Inactive
@agoose77 agoose77 marked this pull request as ready for review July 3, 2023 22:20
@agoose77 agoose77 requested a review from jpivarski July 3, 2023 22:20
@agoose77
Copy link
Collaborator Author

agoose77 commented Jul 3, 2023

@jpivarski did you have any thoughts RE removing the lower bound on NumPy (as we can use the minimum supported Python version as our LB)? I'm not aware of any problems in the wild, but wanted to see if anyone else has concerns.

@jpivarski
Copy link
Member

I noticed that, but I understood why it was happening: Python version ranges now imply NumPy version ranges, so an explicit constraint on NumPy version is redundant.

In the wild, one could circumvent dependency managers when installing these packages. If they then run into an issue with NumPy not supporting NEP-13 or NEP-18, then they brought that problem upon themselves.

@henryiii
Copy link
Member

henryiii commented Jul 3, 2023

It does still help the solver a bit in rare cases (no need to download earlier versions to check compatibility), and has a small user readability benefit, but no strong opinion. If' you'd like to remove it (say to highlight that you support everything valid), that' fine too.

@agoose77
Copy link
Collaborator Author

agoose77 commented Jul 3, 2023

OK, given both of your feedback, I'll err on the side of being explicit here. It might make our lives slightly easier in future if our supported Python deprecation schedule changes relative to NumPy's.

@agoose77 agoose77 enabled auto-merge (squash) July 3, 2023 23:06
@agoose77 agoose77 temporarily deployed to docs-preview July 3, 2023 23:13 — with GitHub Actions Inactive
@agoose77 agoose77 disabled auto-merge July 4, 2023 08:25
@agoose77 agoose77 merged commit 416be5a into main Jul 4, 2023
33 checks passed
@agoose77 agoose77 deleted the agoose77/chore-drop-python-37 branch July 4, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants