-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop Python 3.7 #2557
chore: drop Python 3.7 #2557
Conversation
@henryiii I'd be interested in your thoughts about dropping lower bounds on dependencies that are already implied by the Python version. In this case, the NumPy lower bound is technically 1.18, but that's already imposed by the Python constraint of 3.8. What do you think about this, is it reasonable to remove the LB, or does it remove useful information? |
Codecov Report
Additional details and impacted files
|
@jpivarski did you have any thoughts RE removing the lower bound on NumPy (as we can use the minimum supported Python version as our LB)? I'm not aware of any problems in the wild, but wanted to see if anyone else has concerns. |
I noticed that, but I understood why it was happening: Python version ranges now imply NumPy version ranges, so an explicit constraint on NumPy version is redundant. In the wild, one could circumvent dependency managers when installing these packages. If they then run into an issue with NumPy not supporting NEP-13 or NEP-18, then they brought that problem upon themselves. |
It does still help the solver a bit in rare cases (no need to download earlier versions to check compatibility), and has a small user readability benefit, but no strong opinion. If' you'd like to remove it (say to highlight that you support everything valid), that' fine too. |
OK, given both of your feedback, I'll err on the side of being explicit here. It might make our lives slightly easier in future if our supported Python deprecation schedule changes relative to NumPy's. |
Our deprecation schedule earmarked the July 2.3.0 release for dropping Python 3.7 support. This PR updates our CI, and package metadata, to reflect this change.