fix: prefer known to unknown lengths in broadcasting #2561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first pass over the broadcasting logic to change direction from "unknown lengths are infectious" to "known lengths are infectious".
As we've discussed here previously, typetracer should only fail for ahead-of-time known errors. We defer validation of the unknown data to runtime, via a second pass using a known-data backend. As such, we can rewrite assertions of the form
assert unknown_value == x
withunknown_value = x
, rather than propagating unknown values everywhere.i.e. operations like
become
I think we might have assumed this before; I'm just getting around to changing the code after re-orienting my thinking a while back.
Relatedly, slicing typetracer arrays should assume that the length succeeds, and use the concrete length, for obvious reason.