Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: apply retroactive deprecations #2566

Merged
merged 9 commits into from
Jul 4, 2023
Merged

feat!: apply retroactive deprecations #2566

merged 9 commits into from
Jul 4, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jul 4, 2023 •
edited
Loading

  • Raise error for parameters that are neither None or {} in EmptyForm et al.
    • We still allow parameters=None and parameters={} in the constructor arguments, to ensure that content-naive workflows still work.
  • Raise error for conversions of unions to backend arrays

@agoose77 agoose77 changed the title chore: drop unknown-type parameters chore: apply retroactive deprecations Jul 4, 2023
@agoose77 agoose77 requested a review from jpivarski July 4, 2023 11:48
@agoose77 agoose77 changed the title chore: apply retroactive deprecations feat!: apply retroactive deprecations Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #2566 (c1e8786) into main (f309c4c) will increase coverage by 0.01%.
The diff coverage is 57.69%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/emptyarray.py 75.36% <36.36%> (-1.11%) ⬇️
src/awkward/forms/emptyform.py 84.88% <71.42%> (+0.61%) ⬆️
src/awkward/types/unknowntype.py 79.41% <71.42%> (-7.08%) ⬇️
src/awkward/contents/unionarray.py 85.47% <100.00%> (+0.71%) ⬆️

... and 1 file with indirect coverage changes

@agoose77 agoose77 temporarily deployed to docs-preview July 4, 2023 17:37 — with GitHub Actions Inactive
jpivarski
jpivarski approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right: this makes good on the deprecation promise of forbidding EmptyArray with parameters.

@agoose77 agoose77 merged commit 8fc673c into main Jul 4, 2023
33 checks passed
@agoose77 agoose77 deleted the agoose77/chore-drop-deprecations branch July 4, 2023 18:58
@agoose77 agoose77 mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agoose77 @jpivarski