Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore NEP-18 overloads for concatenate and where #2567

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jul 4, 2023

These were accidentally removed by semgrep when I was refactoring the high-level API in #2531. I've grepped the guilty merge commit to ensure that these are the only two functions.

@agoose77 agoose77 requested a review from jpivarski July 4, 2023 16:45
@agoose77 agoose77 temporarily deployed to docs-preview July 4, 2023 16:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2567 (04b9e2f) into main (0ec6c48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_concatenate.py 96.32% <100.00%> (+0.02%) ⬆️
src/awkward/operations/ak_where.py 92.72% <100.00%> (+0.13%) ⬆️

@jpivarski jpivarski merged commit 1e1d430 into main Jul 4, 2023
35 checks passed
@jpivarski jpivarski deleted the agoose77/fix-restore-nep18-overloads branch July 4, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants