Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use to_backend_array() instead of asarray #2592

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jul 26, 2023

Succinctly, asarray is less powerful than to_backend_array(). It often goes through iterative type discovery, rather than leveraging our internal typed layouts. We should instead be using our internal to_backend_array().

@agoose77 agoose77 temporarily deployed to docs-preview July 26, 2023 21:51 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2592 (e5f6f78) into main (d3e494a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/operations/ak_nan_to_num.py 98.21% <100.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview July 26, 2023 22:01 — with GitHub Actions Inactive
@agoose77 agoose77 marked this pull request as ready for review July 27, 2023 13:07
@agoose77 agoose77 requested a review from jpivarski July 27, 2023 13:13
@agoose77 agoose77 temporarily deployed to docs-preview July 27, 2023 13:23 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay to merge, and it looks like a simple enough change that you're done with it and I can merge it. Thanks!

@jpivarski jpivarski merged commit ce63bf2 into main Jul 28, 2023
35 checks passed
@jpivarski jpivarski deleted the agoose77/fix-asarray branch July 28, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants