Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: assert nextlen == 0 in reducer should also allow unknown_length #2610

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: assert nextlen == 0 in reducer should also allow unknown_length #2610

merged 2 commits into from
Aug 11, 2023

Conversation

jpivarski
Copy link
Member

@jrueb should test this to find out if it's the only blocker, or if there are other (related?) errors down the line.

@jpivarski jpivarski linked an issue Aug 3, 2023 that may be closed by this pull request
TypeError when summing regular array of unknown length #2607
Closed
@jpivarski jpivarski temporarily deployed to docs-preview August 3, 2023 16:43 — with GitHub Actions Inactive
@jrueb
Copy link
Contributor

jrueb commented Aug 4, 2023

This fixes the issue for me.

@jpivarski jpivarski marked this pull request as ready for review August 11, 2023 16:33
@jpivarski
Copy link
Member Author

I should have marked this ready for review last week when @jrueb said it worked. This one ought to go in today's release because it's fixing a bug encountered in the wild. Any chance you could sign off on it today, @agoose77?

@jpivarski
Copy link
Member Author

Thanks!

@jpivarski jpivarski enabled auto-merge (squash) August 11, 2023 16:38
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2610 (9a05082) into main (d1f9892) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/contents/regulararray.py 84.68% <0.00%> (ø)

@jpivarski jpivarski temporarily deployed to docs-preview August 11, 2023 16:48 — with GitHub Actions Inactive
@jpivarski jpivarski merged commit 38eb9ad into main Aug 11, 2023
33 checks passed
@jpivarski jpivarski deleted the jpivarski/issue-2607 branch August 11, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoose77 agoose77 agoose77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError when summing regular array of unknown length
3 participants
@jpivarski @jrueb @agoose77