Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dictionary encoding from Arrow #2630

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Aug 9, 2023

This function is intended to replace ak.to_categorical, which is now deprecated. It is not called by the same name as the Arrow function that implements it, because the Awkward parlance is "convert to categorical", and I think we want our ak.str API to be Awkward-looking, even if it uses Arrow under the hood.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2630 (43de707) into main (6c52131) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/operations/ak_from_categorical.py 95.23% <ø> (ø)
src/awkward/operations/ak_to_categorical.py 93.54% <100.00%> (+0.21%) ⬆️
src/awkward/operations/str/__init__.py 98.82% <100.00%> (+0.01%) ⬆️
src/awkward/operations/str/akstr_to_categorical.py 100.00% <100.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview August 9, 2023 19:28 — with GitHub Actions Inactive
@agoose77 agoose77 requested a review from jpivarski August 9, 2023 19:44
@agoose77 agoose77 temporarily deployed to docs-preview August 9, 2023 19:53 — with GitHub Actions Inactive
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

And I see that the deprecation is already in the wiki.

This is ready to merge.

@agoose77 agoose77 merged commit e2eb69a into main Aug 9, 2023
33 checks passed
@agoose77 agoose77 deleted the agoose77/feat-dict-encode branch August 9, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants