Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support counts=len(array) in ak.unflatten #2632

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Aug 9, 2023

It should be possible to invoke ak.unflatten with the length of the layout, such that it is wrapped in a length-1 RegularArray. However, this currently raises an error because the upper bound of permissible integers is taken to be len(layout)-1.

@agoose77 agoose77 changed the title wip: initial commit fix: support counts=len(array) in ak.unflatten Aug 9, 2023
@agoose77 agoose77 marked this pull request as ready for review August 9, 2023 23:24
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2632 (1801222) into main (e2eb69a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/operations/ak_unflatten.py 96.15% <ø> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview August 9, 2023 23:34 — with GitHub Actions Inactive
@agoose77 agoose77 requested a review from jpivarski August 9, 2023 23:34
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a straightforward bug-fix. I'll merge it; thanks!

@jpivarski jpivarski merged commit cd9ae8c into main Aug 10, 2023
35 of 37 checks passed
@jpivarski jpivarski deleted the agoose77/fix-unflatten-length branch August 10, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants