fix: support non int64
index in ListArray
's pad_none
#2634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
awkward_ListArray_rpad_axis1
)The kernel is written with the following template signature
starts
andtostarts
are expected to have the same dtypes. We can rewrite the kernel call site to ensure that this is true. This bug was observed after reading data from Arrow with 32-bit indices.pad_none
, we shouldn't copy the parameters of the content to the new mask node; this duplicates parameters, and doesn't consider the rules about e.g. whether the content is allowed to possess such parameters.1Footnotes
this remains a general class of problem IIRC with broadcasting that we'll need to work on. However, this fix is also correct; we don't want duplicate parameters. ↩