fix: support placeholders in shape-only routines #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
|
Amongst other things, this PR adds |
jpivarski
approved these changes
Aug 23, 2023
| for item in reversed(x._shape): | ||
| for item in x._shape[-1:0:-1]: |
There was a problem hiding this comment.
This is not just style: it's a change in behavior. Was the original wrong?
We talked about this on Zoom, and yes—it used to be wrong. Now it's right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dask-awkward used its column optimisation to generate placeholder arrays, we were seeing placeholders in some
nplikefunctions that were not prepared for them. This is because these nplike functions explicitly don't touch data for typetracers.This fix won't solve the re-hydration issues by itself, but it should get us closer and is fairly easy to reason about.