fix: support unflattening a typetracer-backed array at axis != 0
#2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
|
agoose77
changed the title
axis != 0
jpivarski
approved these changes
Aug 17, 2023
Comment on lines
-1287
to
+1291
| and len(self) == len(other) | ||
| and ( | ||
| self.length is unknown_length | ||
| or other.length is unknown_length | ||
| or self.length == other.length | ||
| ) |
Comment on lines
-1349
to
+1352
| self._backend.nplike.array_equal(self.data, other.data) | ||
| ( | ||
| not self._backend.nplike.known_data | ||
| or self._backend.nplike.array_equal(self.data, other.data) | ||
| ) |
Comment on lines
-223
to
+225
| self.nplike.array_equal(self.data, other.data) | ||
| and self._data.dtype == other.data.dtype | ||
| ) | ||
| not self._nplike.known_data | ||
| or self._nplike.array_equal(self.data, other.data) | ||
| ) and self._data.dtype == other.data.dtype |
Comment on lines
-211
to
+215
| if not backend.index_nplike.array_equal( | ||
| inneroffsets[positions], outeroffsets | ||
| if ( | ||
| backend.index_nplike.known_data | ||
| and not backend.index_nplike.array_equal( | ||
| inneroffsets[positions], outeroffsets | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2656