-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: deprecate forget_length
, add parameters to typetracer_with_report
#2671
feat!: deprecate forget_length
, add parameters to typetracer_with_report
#2671
Conversation
Codecov Report
Additional details and impacted files
|
forget_length
argument of typetracer_with_report
forget_length
, add parameters to typetracer_with_report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
18bdc1d
to
aa144f8
Compare
@jpivarski could you sign-off on 624634f and ad0fe30 which add |
I think it looks like a good idea. I looked it over while we were talking—splitting my attention, but it was on the same topic—and I can see the usefulness of having a function like this. It's public, but I think it was motivated by an external project. (Was it Tiled? Coffea? I just tried to confirm where I got this impression, but wasn't able to find direct evidence.) |
Both coffea and dask-awkward would benefit from a function like this (see dask-contrib/dask-awkward#351 for an initial cleanup) |
Deprecation of
forget_length
:This argument represents a leak of the implementation details; the function only accepts a form, which has no known length.
In future, we could add a
*, length=unknown_length
keyword-only argument that would be more powerful, but I can't see any examples of people needing that right now.Extend
typetracer_with_report
parametersMost uses of our
typetracer_with_report
function immediately wrap the result with anak.Array
. We should just support that, given that thehighlevel
argument is so widely used in our L1 API. Although typetracer isn't exactly L1, in my view L1-L2 is more about who uses these functions, rather than how painful they can be to use. @jpivarski this might reflect a changing view of mine, I am not sure. Please weigh in you think we should keep these functions "simple".