Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support placeholder arrays in ArrayModuleNumpyLike.frombuffer #2693

Merged
merged 4 commits into from
Sep 5, 2023
Merged

fix: support placeholder arrays in ArrayModuleNumpyLike.frombuffer #2693

merged 4 commits into from
Sep 5, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Sep 5, 2023 •
edited
Loading

This PR:

  • preserves PlaceholderArray instances between ak.to_buffers and ak.from_buffers
  • fixes pickling of Singleton objects like NumpyLike and Backend

Fixes #2674

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #2693 (ebafccf) into main (a8f8552) will increase coverage by 0.04%.
The diff coverage is 85.71%.

Additional details and impacted files
Files Changed Coverage Δ
src/awkward/_nplikes/array_module.py 81.46% <80.00%> (+0.59%) ⬆️
src/awkward/_singleton.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@agoose77 agoose77 temporarily deployed to docs-preview September 5, 2023 14:59 — with GitHub Actions Inactive
jpivarski
jpivarski approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I can see how this was needed, and it looks like a straightforward PR with nothing more to add, so I'll merge it now.

@jpivarski jpivarski enabled auto-merge (squash) September 5, 2023 15:56
@jpivarski jpivarski temporarily deployed to docs-preview September 5, 2023 16:07 — with GitHub Actions Inactive
@jpivarski jpivarski merged commit 684a84d into main Sep 5, 2023
34 checks passed
@jpivarski jpivarski deleted the agoose77/fix-placeholder-frombuffer branch September 5, 2023 16:08
@agoose77 agoose77 mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support placeholders in to_buffers
2 participants
@agoose77 @jpivarski