feat: add Form.is_equal_to
#2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
commented
Dec 1, 2023
jpivarski
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Right, so is_equal_to is a named function because it has a lot of custom arguments for controlling what kind of equality the caller needs. (For instance, "Should parameters count? Which parameters? How about form keys?")
I see that __eq__ is identical to is_equal_to and only defined at the level of the abstract class (Form). That's good.
I see that you've also consolidated some repeated logic in Content._is_equal_to into a helper function.
This all looks good to me! I'll let you decide when to merge it, since you're saying that something is wrong below:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
Type.is_equal_toandContent.is_equal_to. This PR extends this toForm, and fixes some bugs in the existing implementations.