Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing tests after #2877 #2886

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Dec 11, 2023

Just noticed that a few changes in #2877 are making the cuda tests fail. So I have fixed them.

@ManasviGoyal ManasviGoyal marked this pull request as ready for review December 11, 2023 09:35
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #2886 (27b2652) into main (e2510ca) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/_nplikes/cupy.py 37.77% <100.00%> (ø)
src/awkward/_nplikes/jax.py 82.60% <100.00%> (ø)
src/awkward/_nplikes/numpy.py 92.10% <100.00%> (ø)
src/awkward/_nplikes/typetracer.py 74.67% <100.00%> (ø)
src/awkward/_parameters.py 82.22% <100.00%> (ø)
src/awkward/_singleton.py 89.65% <100.00%> (ø)
src/awkward/_typing.py 92.85% <100.00%> (ø)
src/awkward/operations/ak_concatenate.py 85.14% <100.00%> (ø)
src/awkward/operations/ak_from_json.py 93.57% <100.00%> (ø)

@ianna
Copy link
Collaborator

ianna commented Dec 11, 2023

@ManasviGoyal - could you, please, run the linter and fix the warnings? Thanks!

@ManasviGoyal
Copy link
Collaborator Author

@ManasviGoyal - could you, please, run the linter and fix the warnings? Thanks!

I think we need to update the py.version to 3.8 in pyproject.toml to support typing.final. Should I go ahead and go it?

@ianna
Copy link
Collaborator

ianna commented Dec 11, 2023

@ManasviGoyal - could you, please, run the linter and fix the warnings? Thanks!

I think we need to update the py.version to 3.8 in pyproject.toml to support typing.final. Should I go ahead and go it?

why is suddenly failing? what was changed?

@agoose77
Copy link
Collaborator

@ManasviGoyal is right that we should bump the PyLint Python version. I'd missed that when we last updated our Python bounds. I'm not sure why PyLint suddenly started noticing, though. I think we can safely assume that it's a strictness update on their part being pulled in via CI. No need to dig into it, though - we clearly should correct this on our side.

@agoose77
Copy link
Collaborator

@ManasviGoyal don't worry about pylint here - I'll fix it in a new PR.

@ManasviGoyal
Copy link
Collaborator Author

@ManasviGoyal don't worry about pylint here - I'll fix it in a new PR.

Thanks!

@ManasviGoyal
Copy link
Collaborator Author

@ianna I think this can be squash and merged now, right?

@ianna ianna merged commit bf7e37f into main Dec 11, 2023
38 checks passed
@ianna ianna deleted the ManasviGoyal/fix-failing-tests-after-2877 branch December 11, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants