fix: use std::tuple_element_t as an OptionType type alias
#2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::tuple_element_t` was missing on some of the CI nodes. Check if this has changed.
ianna
commented
Jan 23, 2024
There was a problem hiding this comment.
@jpivarski - I think, this is ok to remove the FIXME - since we've moved to C++17 by default. I do not see any CI jobs failing, but it is possible that it is because we do not run the cpp tests on all architectures.
jpivarski
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Yes, std::tuple_element_t is since C++14 and we require C++17:
awkward/awkward-cpp/CMakeLists.txt
Line 44 in 4571af9
So please go ahead and merge this when you see fit. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::tuple_element_twas missing on some of the CI nodes. Check if this has changed. Plus, this PR should trigger all cpp tests to be run.