fix: proper typetracer array slicing in BitMaskedArray
#3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Got it—that makes sense! I followed this through to its definition; the wrapper function is ensuring that the unknown_length singleton becomes a TypeTracerArray scalar, so that it can be used as a slice endpoint.
This is good to merge, and it looks done, so I'll merge it myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long-running design choice was to avoid handling unknown-lengths as indices in
TypeTracerArray; the caller (usuallyContentmethods) would normalise to unknown-scalars (0D arrays).This PR fixes a place where this assumption is not properly ensured, which was surfaced during testing of dask-awkward.
In the long run, I'd be in favour of relaxing this assumption and requiring that
TypeTracerArrayproperly normalise unknown lengths to unknown scalars, but that's out of scope for this fix.