Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ak.flatten and ak.concatenate kernels #3086

Merged
merged 29 commits into from
May 2, 2024
Merged

feat: add ak.flatten and ak.concatenate kernels #3086

merged 29 commits into from
May 2, 2024

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Apr 19, 2024 •
edited

  • Added kernels for ak.flatten and ak.concatenate and their unit and integration tests.
    Also,
  • Removed some dead code
  • Fixed kernel names
  • Added missing PyKernel spec code
  • Fixed most of the FIXME from CPU kernels

@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Apr 19, 2024
@ManasviGoyal ManasviGoyal changed the title feat: add ak.concatenate kernels feat: add ak.flatten and ak.concatenate kernels May 2, 2024
@jpivarski jpivarski mentioned this pull request May 2, 2024
Merged
jpivarski
jpivarski approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I just had one change to request, and I did it as a commit. Check the last commit, and if you're okay with it, go ahead and merge this PR.

I've also run all of the kernel and integration tests on my GPU, as usual.

@ManasviGoyal
Copy link
Collaborator Author

ManasviGoyal commented May 2, 2024 •
edited

Awesome! I just had one change to request, and I did it as a commit. Check the last commit, and if you're okay with it, go ahead and merge this PR.

I've also run all of the kernel and integration tests on my GPU, as usual.

Looks good. I will merge it once the tests pass. Thanks!

@jpivarski jpivarski enabled auto-merge (squash) May 2, 2024 15:00
@jpivarski jpivarski merged commit 464697a into main May 2, 2024
40 of 41 checks passed
@jpivarski jpivarski deleted the ManasviGoyal/priority-kernels branch May 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
gpu Concerns the GPU implementation (backend = "cuda')
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ManasviGoyal @jpivarski