Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): allow running from Python 3.7 #542

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(types): allow running from Python 3.7 #542

merged 1 commit into from
Mar 23, 2021

Conversation

henryiii
Copy link
Member

No description provided.

@github-actions github-actions bot added the needs changelog Might need a changelog entry label Mar 22, 2021
@henryiii henryiii closed this Mar 23, 2021
@henryiii henryiii reopened this Mar 23, 2021
@github-actions github-actions bot removed the needs changelog Might need a changelog entry label Mar 23, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 23, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.61 ⭐ 0.61 ⭐ 0.00
Method Length 82.38 🙂 82.38 🙂 0.00
Working memory 8.11 🙂 8.11 🙂 0.00
Quality 72.59% 🙂 72.59% 🙂 0.00%
Other metrics Before After Change
Lines 142 142 0
Changed files Quality Before Quality After Quality Change
tests/test_accumulators.py 72.59% 🙂 72.59% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
tests/test_accumulators.py test_sum_weighed_mean 0 ⭐ 162 😞 10 😞 61.70% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_accumulators.py test_sum_mean 0 ⭐ 114 🙂 10 😞 67.14% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@henryiii henryiii merged commit 67b96f0 into develop Mar 23, 2021
@henryiii henryiii deleted the fix/types37 branch March 23, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant