Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new histogram version #65

Merged
merged 2 commits into from May 10, 2019

Conversation

HDembinski
Copy link
Member

@HDembinski HDembinski commented May 10, 2019

This version has the private variant implementation, which together with a few other things now allows us to drop most of the external dependencies.

@HDembinski
Copy link
Member Author

Works like a charm on my computer, now I am going to remove the now superfluous externals...

@HDembinski HDembinski requested a review from henryiii May 10, 2019 12:16
@henryiii
Copy link
Member

Azure is configured correctly now for PRs from forks. 👍

Copy link
Member

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, more than half of the externals removed and passes tests. Let's merge!

@henryiii henryiii changed the title update to new histogram version Update to new histogram version May 10, 2019
@henryiii henryiii merged commit 499f429 into scikit-hep:develop May 10, 2019
@henryiii
Copy link
Member

Let's benchmark before and after 499f429, so see if there's a difference in any-histogram.

Also TODO: Remove the MPL limit setting.

@HDembinski HDembinski deleted the histogram_new_variant branch May 21, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants