Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fit
function in the CLI has the structurehttps://github.com/alexander-held/cabinetry/blob/d888ec054e080f474a12de6de375857631c55987/src/cabinetry/cli/__init__.py#L134-L137
and both branches are tested:
https://github.com/alexander-held/cabinetry/blob/d888ec054e080f474a12de6de375857631c55987/tests/cli/test_cli.py#L172-L182
In CI, where the coverage is calculated with Python 3.7, everything shows up as covered. When using Python 3.8 it does not. This is presumably due to a CPython optimization, and can seemingly be fixed by the addition of a
pass
:https://github.com/alexander-held/cabinetry/blob/1a11641e214072c3922d7a1269304c97754496b8/src/cabinetry/cli/__init__.py#L138
This PR adds this
pass
and a link to a coverage issue which discusses what I believe is the same underlying issue.