fix: avoid mixing different versions of awkward in uproot5 tests #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests of the most recent versions of dependencies started failing for
uproot5
. The reason is thatuproot5
uses theawkward
v2 API, but the histogram creation code incabinetry
usesawkward
directly as well (which currently results in v1). The two do not mix:results in
The solution is to call
.to_numpy()
on the relevant arrays instead, which will then use the v2 API in these tests. Asuproot5
andawkward
v2 should release at the same time, this probably would not have an impact on users, but this change should keep the tests working.