Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update lower bound of pyhf to v0.7.0rc2 #361

Merged
merged 1 commit into from Aug 30, 2022

Conversation

matthewfeickert
Copy link
Member

v0.7.0rc2 fixes a regression in staterror introduced after v0.6.3 and so is present in v0.7.0rc1.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (fd3c197) compared to base (84c7367).
Patch has no changes to coverable lines.

❗ Current head fd3c197 differs from pull request most recent head d2fa5f8. Consider uploading reports for the commit d2fa5f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2010      2009    -1     
  Branches       327       326    -1     
=========================================
- Hits          2010      2009    -1     
Impacted Files Coverage Δ
src/cabinetry/workspace.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

* v0.7.0rc2 fixes a regression in staterror introduced after v0.6.3
  and so is present in v0.7.0rc1.
Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for propagating this update (and the RC of course)!

* update lower bound of pyhf to v0.7.0rc2 to fix staterror regression

@alexander-held alexander-held merged commit b39a695 into master Aug 30, 2022
@alexander-held alexander-held deleted the build/update-pyhf-rc branch August 30, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants