Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for builtin dir() #393

Merged
merged 2 commits into from
Mar 21, 2023
Merged

test: add test for builtin dir() #393

merged 2 commits into from
Mar 21, 2023

Conversation

alexander-held
Copy link
Member

#386 added __all__ and dir() for cabinetry, but did not include a test and coverage for that, which is added by this PR.

* test and cover dir(cabinetry)

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (ac28726) 99.95% compared to head (c14d40e) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #393      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files          23        23              
  Lines        2046      2046              
  Branches      324       324              
===========================================
+ Hits         2045      2046       +1     
+ Misses          1         0       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held merged commit bab591c into master Mar 21, 2023
@alexander-held alexander-held deleted the test/dir-coverage branch March 21, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant