Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adopt typeguard version 4.0 #406

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: adopt typeguard version 4.0 #406

merged 3 commits into from
May 15, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented May 12, 2023

Relax the requirement of typeguard<3 introduced in #392 and adopt version 4.0.

The update of typeguard however now interacts with code coverage calculations, lowering the reported coverage: agronholm/typeguard#356. To avoid this, run pytest for Python 3.8 without typeguard to calculate coverage, and run typeguard only for the remaining Python versions.

resolves #391

* require typeguard>=4.0
* calculate code coverage using Python 3.8 without typeguard enabled
* remove typing workarounds that are no longer required

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10525d0) 100.00% compared to head (ff2d1ff) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #406   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2068      2068           
  Branches       334       334           
=========================================
  Hits          2068      2068           
Impacted Files Coverage Δ
src/cabinetry/smooth.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-held alexander-held merged commit 063dcd0 into master May 15, 2023
7 checks passed
@alexander-held alexander-held deleted the fix/typeguard-4 branch May 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt typeguard version 4.0
1 participant