Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn warnings about missing post-processed histograms into info messages #436

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Sep 19, 2023

The WARNING log level when histogram post-processing is not called seemed a bit too high. This is now an INFO level message instead.

Extending the typeguard version restrictions to handle #428.

resolves #432

* lower warning-level messages when histogram post-processing is not used to info-level messages
* temporarily restrict more typeguard versions to avoid typing_extensions conflict due to TensorFlow

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a0638e1) 100.00% compared to head (89bad89) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2072      2071    -1     
  Branches       338       338           
=========================================
- Hits          2072      2071    -1     
Files Changed Coverage Δ
src/cabinetry/histo.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit 2b7c091 into master Sep 19, 2023
7 checks passed
@alexander-held alexander-held deleted the feat/postprocess-log branch September 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings about missing post-processed histograms
1 participant