build: relax typeguard constraints following TensorFlow release #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2082 2082
Branches 340 340
=========================================
Hits 2082 2082 ☔ View full report in Codecov by Sentry. |
alexander-held
force-pushed
the
build/relax-typeguard-4
branch
from
355c911
to
d2517cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid a
typing_extensionclash caused by TensorFlow, #429 restricted thetypeguardversion listed in thetestsetup extra. Now that an updated TensorFlow version is available, which fixes this clash, thetypeguardversion restriction can be relaxed again.The
typing-extensionscap introduced intensorflow-probabilityhas been fixed, but the versions with the fix are Python 3.9+ and therefore cause issues in the CI for 3.8. To avoid this, upgrade thetyping_extensionsversion in the relevant Python 3.8 CI.resolves #428