-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to setup.cfg #129
Conversation
c259d3b
to
30ed146
Compare
The issue with Python 3.5 is solvable for sure but I'm perfectly happy to drop support for it in the next minor release, so ... |
Weird, why is lark missing on 3.5? |
It isn't as I can see from the CI from my PR. So maybe a weird glitch? In any case it seems we can get rid of 3.5 anyway at this stage :-). |
The CI for Python 3.5 in the step "Install package" says
whereas for the other versions is starts collecting and installing the required packages. |
OK, GA also fails on Python 3.5. So it's got to do with our setup. The only thing I see removed is |
Ahh, pyproject.toml is missing. I think that’s the problem. |
Dunno. Will you take care of adding one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Noted that there is more on Scikit-HEP guidelines but this one PR is scoped and ready).
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 12.77%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Yes, one step at a time. If you want to add one of the other parts (setuptools_scm, more checks, etc), feel free. I'll try to ping you if I start working on one. |
OK, sounds good. I actually found a bug in decay chain representations so will probably focus on that first, tough; for next week. |
Converting to setup.cfg. Automatic + minor touchup manually.