Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to setup.cfg #129

Merged
merged 7 commits into from
Mar 26, 2021
Merged

chore: update to setup.cfg #129

merged 7 commits into from
Mar 26, 2021

Conversation

henryiii
Copy link
Member

Converting to setup.cfg. Automatic + minor touchup manually.

setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@eduardo-rodrigues
Copy link
Member

The issue with Python 3.5 is solvable for sure but I'm perfectly happy to drop support for it in the next minor release, so ...

@henryiii
Copy link
Member Author

Weird, why is lark missing on 3.5?

@eduardo-rodrigues
Copy link
Member

It isn't as I can see from the CI from my PR. So maybe a weird glitch? In any case it seems we can get rid of 3.5 anyway at this stage :-).

@henryiii henryiii closed this Mar 25, 2021
@henryiii henryiii reopened this Mar 25, 2021
@eduardo-rodrigues
Copy link
Member

The CI for Python 3.5 in the step "Install package" says

Installing collected packages: UNKNOWN
  Running setup.py develop for UNKNOWN
Successfully installed UNKNOWN
Finishing: Install package

whereas for the other versions is starts collecting and installing the required packages.

setup.cfg Outdated Show resolved Hide resolved
@eduardo-rodrigues
Copy link
Member

OK, GA also fails on Python 3.5. So it's got to do with our setup. The only thing I see removed is tests_require=extras["test"],.

@henryiii
Copy link
Member Author

Ahh, pyproject.toml is missing. I think that’s the problem.

@eduardo-rodrigues
Copy link
Member

Ahh, pyproject.toml is missing. I think that’s the problem.

Dunno. Will you take care of adding one?

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Noted that there is more on Scikit-HEP guidelines but this one PR is scoped and ready).

pyproject.toml Outdated Show resolved Hide resolved
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 12.77%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 42.00 ⭐ 12.33 ⭐ -29.67 👍
Working memory 16.40 ⛔ 6.80 🙂 -9.60 👍
Quality 75.10% 87.87% 12.77% 👍
Other metrics Before After Change
Lines 78 10 -68
Changed files Quality Before Quality After Quality Change
setup.py 75.10% ⭐ 87.87% ⭐ 12.77% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@henryiii
Copy link
Member Author

Yes, one step at a time. If you want to add one of the other parts (setuptools_scm, more checks, etc), feel free. I'll try to ping you if I start working on one.

@eduardo-rodrigues
Copy link
Member

Yes, one step at a time. If you want to add one of the other parts (setuptools_scm, more checks, etc), feel free. I'll try to ping you if I start working on one.

OK, sounds good. I actually found a bug in decay chain representations so will probably focus on that first, tough; for next week.

@henryiii henryiii merged commit 9e201f1 into master Mar 26, 2021
@henryiii henryiii deleted the chore/setupcfg branch March 26, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants