Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing package dependency on particle #16

Merged
merged 15 commits into from
Mar 29, 2019

Conversation

eduardo-rodrigues
Copy link
Member

No description provided.

@eduardo-rodrigues eduardo-rodrigues changed the title Preparing package dependency on particle [WIP] Preparing package dependency on particle Mar 8, 2019
@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage decreased (-55.3%) to 0.0% when pulling 789eb1c on eduardo-particle-package into 3b0588a on master.

@eduardo-rodrigues
Copy link
Member Author

There's one test failing but it's in fact the same issue as before this PR was created. I would address this problem in a separate PR, since totally unrelated to the matters at hand here.

@eduardo-rodrigues eduardo-rodrigues changed the title [WIP] Preparing package dependency on particle Preparing package dependency on particle Mar 8, 2019
@eduardo-rodrigues
Copy link
Member Author

This PR will not have all checks green until we get out a new release of particle. To be done asap.

@henryiii
Copy link
Member

@eduardo-rodrigues , particle no longer allows custom three_charges but pulls them from the PDGID. Unfortunately, this means some of the custom particles loaded here can't be used, since they don't have a valid PDGID code. I think we need to re-add charge as a property/column in the table, and check to make sure they match for the official particles. I'll probably try to improve the behavior as well for repr on a non-valid particle.

We could also make three_charge optional.

@eduardo-rodrigues
Copy link
Member Author

Yes, that's a good point. Reminds me of the comment I put in the convert.py file in particle:

    # These items are not very important - can be reconstructed from the PDG ID
    # TODO: maybe first check the consistency between what is read in and what the PDG ID provides (being maniac)?
    del full['Charge'], full['J']

Spot on :-).

eduardo-rodrigues added a commit to scikit-hep/particle that referenced this pull request Mar 23, 2019
)

* Deal with decaylanguage failure in pull #16

* CHANGELOG update
@eduardo-rodrigues
Copy link
Member Author

As agreed, merging this big PR at this stage. The error is rather different from the previous ones, and should be addressed in dedicated developments asap.

@eduardo-rodrigues eduardo-rodrigues merged commit 65e84cb into master Mar 29, 2019
@henryiii henryiii deleted the eduardo-particle-package branch April 5, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants