-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparing package dependency on particle #16
Conversation
8b2ff38
to
6093bf7
Compare
6093bf7
to
2823930
Compare
There's one test failing but it's in fact the same issue as before this PR was created. I would address this problem in a separate PR, since totally unrelated to the matters at hand here. |
4299b64
to
c82ab7b
Compare
This PR will not have all checks green until we get out a new release of |
@eduardo-rodrigues , particle no longer allows custom three_charges but pulls them from the PDGID. Unfortunately, this means some of the custom particles loaded here can't be used, since they don't have a valid PDGID code. I think we need to re-add charge as a property/column in the table, and check to make sure they match for the official particles. I'll probably try to improve the behavior as well for repr on a non-valid particle. We could also make three_charge optional. |
Yes, that's a good point. Reminds me of the comment I put in the
Spot on :-). |
) * Deal with decaylanguage failure in pull #16 * CHANGELOG update
As agreed, merging this big PR at this stage. The error is rather different from the previous ones, and should be addressed in dedicated developments asap. |
No description provided.