Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Mint .csv file for new specifications in the Particle package #20

Merged
merged 5 commits into from
Apr 5, 2019

Conversation

eduardo-rodrigues
Copy link
Member

While at it, I also added a README file for the decaylanguage.data directory
and switched off a test related to work-in-progress code, as it makes little sense to run a broken test until the related code is updated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 3032250 on eduardo-mint-particles-update into 0e2a2bb on master.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage remained the same at 0.0% when pulling 8a2516d on eduardo-mint-particles-update into 0e2a2bb on master.

@eduardo-rodrigues
Copy link
Member Author

@henryiii, any idea how to fix the check in tox.ini? In fact, is it at all needed?

@eduardo-rodrigues
Copy link
Member Author

Hi @henryiii, this PR is now a 2-in-1:

  • The PR itself.
  • Check run on Windows now switched off so that the tests run OK (some, WIP, are still skipped).

I would go ahead and merge this, suggesting we do not invest more time on the present CI and rather move to using the Azure pipelines as for the Particle package. I can open an "issue" and merge this if you are in agreement.

Thanks.

@henryiii
Copy link
Member

henryiii commented Apr 5, 2019

Looks fine. We'll probably set the testing up on Azure so quite a bit of that will probably change.

@eduardo-rodrigues eduardo-rodrigues merged commit 584ad01 into master Apr 5, 2019
@henryiii henryiii deleted the eduardo-mint-particles-update branch April 5, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants