-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new DecFileParser class, with test suite #21
Conversation
I will be adding a bit more doc, in particular. But the code is otherwise up for discussion, @henryiii. |
@henryiii, this is now ready for review, though I will still add some more documentation, and am also thinking about an extra method to display a la dot-file a decay chain, for example. |
Can you rebase to see if this starts passing? Looks good otherwise. I might recommend a |
…ed helper functions
1a1804e
to
062837c
Compare
1458457
to
acc8f74
Compare
acc8f74
to
8447fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More docs and things would be good, though I'm okay to go ahead and merge, then add to it afterwards in a new PR.
…ed helper functions
Thanks a lot for the look and the improvements/fixes. I've just rebased. |
Forgot to say: I do want to add more docs, and tests, though I put a significant amount of it already. I will merge, then, as this PR is rather large and contains some nice additions. Thanks. |
With this new
DecFileParser
class I was able to trivially parse and check the master LHCb DECAY.DEC file:The massive file is nicely parsed in under 2 seconds :-).
And, BTW, I found a little bug in the file - duplication of decay definition for the Sigma(1775)0 particle! LHCb simulation group about to be informed ...