Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test decay files #25

Merged
merged 4 commits into from
Apr 6, 2019
Merged

New test decay files #25

merged 4 commits into from
Apr 6, 2019

Conversation

eduardo-rodrigues
Copy link
Member

Adding a handful of .dec decay files for testing purposes.

@henryiii, what's your take on the location of such files? They are under decaylanguage/data but we could as well have then under a new directory tests/data.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 0ebfbb3 on eduardo-testdata into 26d7ead on master.

@coveralls
Copy link

coveralls commented Apr 5, 2019

Coverage Status

Coverage remained the same at 0.0% when pulling d8c9bb9 on eduardo-testdata into 26d7ead on master.

@henryiii
Copy link
Member

henryiii commented Apr 5, 2019

Testing files should be in tests, since you don't want to distribute them in the package. If something might be of general use (a full file like the LHCb one), that can be in the package in data.

@eduardo-rodrigues eduardo-rodrigues changed the title Test decay files New test decay files Apr 5, 2019
@eduardo-rodrigues
Copy link
Member Author

That's my opinion too. All test files moved to new directory tests/data.

@eduardo-rodrigues eduardo-rodrigues merged commit 8bb2cbd into master Apr 6, 2019
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-testdata branch April 19, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants