-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pre-commit hooks #434
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0)
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @henryiii for the improvements.
BTW, concerning a future release - will we have the same issues as with the latest release of Particle where you acted manually and moved to trusted publishers on PyPI? Maybe you got that all done already across project packages? |
Probably, all Scikit-HEP repos had their secrets stripped. It's not trivial enough to do access all packages, especially ones like iminuit that have custom deploy structures. |
FYI, we need to work on reducing the type ignores. Most of them are probably hiding issues in typing rather than deficiencies in the type checkers. |
Yes, this is the way you can tell it is not using trusted-publishers: decaylanguage/.github/workflows/wheel.yml Line 42 in cb0a861
|
OK, then I need to find some time to understand how to do what you did for Particle, as there is this package but also scikit-hep and hepunits ... Yes, I totally agree with you that type ignores are to be avoided as much as possible. I will create now an issue for it. |
updates: