Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #434

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 29, 2024

pre-commit-ci bot and others added 2 commits April 29, 2024 21:05
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2)
- [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0)
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @henryiii for the improvements.

@eduardo-rodrigues eduardo-rodrigues merged commit cb0a861 into master Apr 30, 2024
10 checks passed
@eduardo-rodrigues eduardo-rodrigues deleted the pre-commit-ci-update-config branch April 30, 2024 08:23
@eduardo-rodrigues
Copy link
Member

BTW, concerning a future release - will we have the same issues as with the latest release of Particle where you acted manually and moved to trusted publishers on PyPI? Maybe you got that all done already across project packages?

@henryiii
Copy link
Member

Probably, all Scikit-HEP repos had their secrets stripped.

It's not trivial enough to do access all packages, especially ones like iminuit that have custom deploy structures.

@henryiii
Copy link
Member

FYI, we need to work on reducing the type ignores. Most of them are probably hiding issues in typing rather than deficiencies in the type checkers.

@henryiii
Copy link
Member

Yes, this is the way you can tell it is not using trusted-publishers:

password: ${{ secrets.pypi_password }}

@eduardo-rodrigues
Copy link
Member

OK, then I need to find some time to understand how to do what you did for Particle, as there is this package but also scikit-hep and hepunits ...

Yes, I totally agree with you that type ignores are to be avoided as much as possible. I will create now an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants