Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert to mime bundle for IPython reprs #379

Closed
henryiii opened this issue Feb 27, 2022 · 2 comments · Fixed by #388
Closed

chore: convert to mime bundle for IPython reprs #379

henryiii opened this issue Feb 27, 2022 · 2 comments · Fixed by #388
Assignees
@amangoel185
Labels
enhancement New feature or request

Comments

@henryiii
Copy link
Member

Let's convert _repr_svg_ (and any extras) to _repr_mimebundle_. See scikit-hep/decaylanguage#213.
@henryiii henryiii changed the title [BUG] chore: convert to mime bundle for IPython reprs Feb 27, 2022
@amangoel185 amangoel185 added the enhancement New feature or request label Feb 27, 2022
@henryiii
Copy link
Member Author

With this, we can also return nothing if the plot is too complex (I think), and that will revert to repr. I think. See #380

@henryiii
Copy link
Member Author

Looks like we can return nothing with the html version too, so will use that.

@henryiii henryiii mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amangoel185 amangoel185

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: repr limit and fallback on normal repr scikit-hep/hist
2 participants
@henryiii @amangoel185