fix: repr limit and fallback on normal repr #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/repr
branch
2 times, most recently
from
345c0f8
to
a2b518e
Compare
henryiii
commented
Mar 10, 2022
| @@ -87,37 +87,37 @@ def __init__( | |||
| for a in args | |||
| ] | |||
|
|
|||
| if args: | |||
There was a problem hiding this comment.
I just completely removed this if, wasn't needed, and it caused the super().__init__ to never get called.
There was a problem hiding this comment.
(If you hide whitespace in the GitHub diff, you'll see basically nothing changed really here except this line)
henryiii
force-pushed
the
henryiii/fix/repr
branch
from
a2b518e
to
7abccb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #379 . Also fixes an issue with an empty histogram breaking by not initializing. This adds a hardcoded limit on the SVG size, 1000 for 1D and 200 in either diminsion for 2D (can increase if we move to using a bitmap). Closes #380. We could make this configurable possibly, but a hard limit is just fine at the moment too - you can always plot, this is just a visual helper.