Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Remove private copy of six package and rather use external version #6

Merged
merged 2 commits into from Oct 25, 2018

Conversation

eduardo-rodrigues
Copy link
Member

As per our discussion @henryiii.

@henryiii
Copy link
Member

You'll need to remove 'numpythia.extern', from the setup.py main function, too. This is one of the reasons listing them there manually is a bad idea...

@eduardo-rodrigues
Copy link
Member Author

Yep, noticed it and remove it - had indeed overlooked, not seeing it when grep'ing for 'six' somehow.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4: 0.0%
Covered Lines: 0
Relevant Lines: 22

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 24, 2018

Pull Request Test Coverage Report for Build 33

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+35.2%) to 100.0%

Totals Coverage Status
Change from base Build 23: 35.2%
Covered Lines: 22
Relevant Lines: 22

💛 - Coveralls

@eduardo-rodrigues
Copy link
Member Author

Hi @henryiii, the issue is that same as the one we talked about yesterday. It's got to do with a mix-up when unittest tries to run. Will you have time to make the move to pytest as you suggested?

@henryiii
Copy link
Member

Yes, later today. Would you like me to work on this branch or a new one and then you can merge this one?

@eduardo-rodrigues
Copy link
Member Author

Brilliant!
As you prefer … We can even change the PR title to incorporate both things.

@henryiii
Copy link
Member

Okay, I'll work here then.

@eduardo-rodrigues
Copy link
Member Author

Thanks a lot @henryiii!

@eduardo-rodrigues eduardo-rodrigues merged commit 2c09ce3 into master Oct 25, 2018
@eduardo-rodrigues eduardo-rodrigues deleted the erodrigu-remove-six branch March 19, 2019 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants