Skip to content

Commit

Permalink
fix: Use str object for jupyterlite-sphinx jupyterlite_dir config (#2458
Browse files Browse the repository at this point in the history
)

* To avoid warning

WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`.

 use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config
 option.
* Update jupyterlite-sphinx lower bound to v0.13.1 in 'docs' extra.
* Amends PR #2300
  • Loading branch information
matthewfeickert committed Mar 22, 2024
1 parent 428c9e1 commit 39db83b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -531,5 +531,5 @@ def setup(app):
linkcheck_retries = 50

# JupyterLite configuration
# Use Path as jupyterlite-sphinx expects PosixPath
jupyterlite_dir = Path("lite")
# jupyterlite-sphinx v0.13.0+ expects str
jupyterlite_dir = str(Path("lite"))
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ docs = [
"ipywidgets",
"sphinx-issues",
"sphinx-copybutton>=0.3.2,!=0.5.1",
"jupyterlite-sphinx>=0.8.0",
"jupyterlite-sphinx>=0.13.1", # c.f. https://github.com/scikit-hep/pyhf/pull/2458
"jupyterlite-pyodide-kernel>=0.0.7",
"jupytext>=1.14.0",
"ipython!=8.7.0", # c.f. https://github.com/scikit-hep/pyhf/pull/2068
Expand Down

0 comments on commit 39db83b

Please sign in to comment.