-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for staterror modifier #1018
Comments
@paulgessinger given your comments on the |
I guess mentioning that it's the absolute error would be a good idea (although that's what I personally assumed to be the case). Apart from that, if my understanding that the alternative to |
It's a matter of how you model the uncertainty. For example, a shapesys is useful to apply an uncertainty on a particular sample in a channel... whereas, if all your MC samples are generated with some correlated (generator-based, statistical) uncertainty -- then a staterror is more appropriate. |
Related to this, there is also an issue with the Modifiers and Constraints table, where the form of the gaussian and the input would have the data in the modifier definition be the relative variance rather than the absolute standard deviation. I think the constraint term should be |
Question
The staterror documentation https://scikit-hep.org/pyhf/likelihood.html#mc-statistical-uncertainty-staterror shows a modifier example:
but does not clarify what exactly it is that should be specified under
data
. In particular, a user may wonder whether they should put the relative or absolute stat. uncertainty (the absolute is needed).Users may also wonder why a Gaussian constraint term is used, and/or how to switch to a Poisson term which is available in ROOT HistFactory (see #760).
In the formula provided in the text, is the summation not in quadrature?
small typo in the text: "constrained term" -> "constraint term"
came up in conversation with @kratsg
Relevant Issues and Pull Requests
#760
The text was updated successfully, but these errors were encountered: